Count VPN controller cancellations #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
diegoreymendez
changed the title
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
samsymons
reviewed
May 1, 2024
DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionTunnelController.swift
Outdated
Show resolved
Hide resolved
…ProtectionTunnelController.swift Committing a change from a code review comment. Co-authored-by: Sam Symons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207193126056882/f
Description
Stop counting when the user disables the VPN configuration creation as a controller start failure.
Testing
IMPORTANT: there's an issue that's causing the VPN allow dialog to come up twice, I'm currently debugging this but haven't reached a conclusion yet.
netp_controller_start_cancelledInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation